Sync with aosp/main #17
Conversation
| @@ -1678,6 +1706,10 @@ void DualModeController::SetEventFilter(CommandView command) { | |||
| DEBUG(id_, " filter_type={}", | |||
| bluetooth::hci::FilterTypeText(command_view.GetFilterType())); | |||
|
|
|||
| if (command_view.GetFilterType() != bluetooth::hci::FilterType::CLEAR_ALL_FILTERS) { | |||
There was a problem hiding this comment.
@hchataing - This particular change will not work with my specific use case. The BT stack I'm using sends SentEventFilter commands. Could you provide my clarity about why this was added and if there are other ways that we can work around this?
There was a problem hiding this comment.
Hi @akuker, thanks for reporting. I added this check in lieu of a full implementation, since the feature was apparently unused in our testing context.
I will provide a full implementation if you to need it 👍
There was a problem hiding this comment.
I am interested to know how your are using Rootcanal by the way, that will help me anticipate similar issues in the future 😄
There was a problem hiding this comment.
Hi @hchataing . Thank you for the quick response!
A full implementation would be nice, but not 100% required. Our simulation seemed to be OK without it.
For our use case, we are simulating smart home / IoT devices and using netsim/rootcanal to connect them all together. Depending upon the test scenario, we spin up one or more AOSP emulator devices to test interaction between the phones and devices. For this specific issue, the smart home device is using a BT stack derived from Bluedroid.
We started out using the Bumble link relay, but it doesn't look like there is a lot of activity in that area.
I have a number of other minor feature requests/questions about netsim. Is there an appropriate forum to ask those? Is https://issuetracker.google.com/ appropriate? (since this is just a mirror of the AOSP repo)
There was a problem hiding this comment.
Thank you for the answer ! https://issuetracker.google.com/ is a good place to post your questions.
You may use componentid:1261108 for requests that are specific to Bluetooth emulation,
and componentid:1203577 for more general questions (e.g. emulator integration).
There was a problem hiding this comment.
Hi, sorry for the delay.
These components are not public apparently.
I will check how to change the privacy setting, meanwhile feel free to report change requests in github issues
and I will upload them to the issue tracker
There was a problem hiding this comment.
I started working on implementing the HCI Set Event Filter command in RootCanal, but I would like to go further with the update as I won't finish it soon. I suggest an older version of RootCanal until I release the implementation.
There was a problem hiding this comment.
Thank you for the update @hchataing ! (apologies for the delay - I was offline for a couple weeks)
For now, I'm using a patched version of netsim/rootcanal with those few lines removed.
I'm going to add a couple feature requests to this github project, since I don't have access in issuetracker. Hopefully that's OK!
There was a problem hiding this comment.
I commented out the hard assert on the Event Filter type in the github version to avoid breaking your use case; it will stay this way until I get around to actually implementing the command.
It's perfectly OK to add the feature requests to the github project :)
There was a problem hiding this comment.
I also found a work-around using Bumble's hci-bridge to short circuit that particular command. So, I should be good using the standard implementation.
Thank you again for your support!! :)
hchataing
force-pushed
the
aosp-sync
branch
3 times, most recently
from
3fa658e to
bcabd27
Compare
hchataing
force-pushed
the
aosp-sync
branch
5 times, most recently
from
2409c37 to
6f9db33
Compare
Synchronized to packages/modules/Bluetooth commit 62a71c25ab79ef9b854ef4e1c5b71f98f0f74966
Synchronized to packages/modules/Bluetooth
commit 62a71c25ab79ef9b854ef4e1c5b71f98f0f74966