Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PbMapMixin, Dart mixin support #883

Closed
wants to merge 2 commits into from
Closed

Conversation

osa1
Copy link
Member

@osa1 osa1 commented Oct 13, 2023

This removes the last Dart mixin PbMapMixin. The mixin is not used
internally, and GitHub code search also doesn't find any uses other than in
forks of this repo (1, 2).

To keep the API surface small to make changes and migrations easier this PR
removes the mixin.

Because PbMapMixin was the only mixin left (after #880), this also removes
the Dart mixin support from the plugin.

cl/575127174

@osa1
Copy link
Member Author

osa1 commented Oct 17, 2023

Note to self: clarify that this removes the built-in mixins. Users can still add arbitrary mixins to their message classes via the Dart options (https://github.com/google/protobuf.dart/blob/master/protoc_plugin/protos/dart_options.proto#L40).

Also mention this in the changelog.

@osa1
Copy link
Member Author

osa1 commented Oct 25, 2023

It turns out this mixin has users. See cl/575127174 for details. Closing.

@osa1 osa1 closed this Oct 25, 2023
@osa1 osa1 deleted the remove_mixins branch October 25, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants