Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send multicastNtf back in delete action. #90

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Only send multicastNtf back in delete action. #90

merged 3 commits into from
Jun 5, 2024

Conversation

bobwzy
Copy link
Collaborator

@bobwzy bobwzy commented Jun 3, 2024

From Fira 2.0 spec:
The UWBS shall send the SESSION_UPDATE_CONTROLLER_MULTICAST_LIST_NTF only in case of an error encountered when the session is started, after receiving the RANGE_START_CMD from the Host. This scenario can be encountered only when the UWBS fails to fetch the Session key/Sub-Session Key from the Secure Component.

Since we get session key/sub-session key from host, we don't need to send ntf
back. So move the logic into RemoveControlee branch.

@bobwzy bobwzy requested review from hchataing and SilverBzH June 3, 2024 22:13
src/device.rs Outdated Show resolved Hide resolved
@bobwzy bobwzy requested a review from hchataing June 4, 2024 07:30
@bobwzy bobwzy merged commit 94bd273 into main Jun 5, 2024
6 checks passed
@bobwzy bobwzy deleted the multicastNtf branch June 5, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants