expanded verbose for all algorithms, made verbose a boolean for all algorithms #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mblondel
reviewed
Oct 10, 2023
jaxopt/_src/armijo_sgd.py
Outdated
| @@ -224,7 +224,7 @@ class ArmijoSGD(base.StochasticSolver): | |||
| maxiter: int = 500 | |||
| maxls: int = 15 | |||
| tol: float = 1e-3 | |||
| verbose: int = 0 | |||
| verbose: bool = False | |||
There was a problem hiding this comment.
The idea of using an int was that we could have several levels of verbosity:
- 1: verbose
- 2: very verbose
- 3: very very verbose
For example, 2 could be used to print linesearch information.
Do you think it's unnecessary?
There was a problem hiding this comment.
I did a two level verbose for the solvers with linesearch as you suggested.
I made all verbose types to be boolean or int to be consistent.
Thanks for the suggestion!
jaxopt/_src/armijo_sgd.py
Outdated
| next_state, | ||
| error_name="Grad. Norm", | ||
| additional_info={ | ||
| 'Obj. Val.': next_state.value, |
There was a problem hiding this comment.
I would avoid abbreviations, e.g., I prefer Objective value here.
vroulet
force-pushed
the
detailed_verbose
branch
2 times, most recently
from
ba72a61 to
100c0b6
Compare
vroulet
force-pushed
the
detailed_verbose
branch
from
100c0b6 to
9e173ac
Compare
vroulet
force-pushed
the
detailed_verbose
branch
from
9e173ac to
754e5ee
Compare
|
I changed the logging for the Zoom linesearch to partially fix the issue #555 (that is avoid printing errors when not required). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced "Error" by specific name of error considered and added other information when verbose=True.
Should be useful for debugging more quickly.
All verbose are now boolean too (some were int).