Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the computed initialization of the jac approx in Broyden #529

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zaccharieramzi
Copy link
Contributor

@zaccharieramzi zaccharieramzi commented Sep 10, 2023

WIP: need to run the existing tests and add the previously failing test written by @vroulet in a previous PR

In order to implement this change, I had to change the dtype of gamma which is now a pytree rather than a scalar, since it can be different for each leaf of the parameters.

@zaccharieramzi
Copy link
Contributor Author

So actually the failure that @vroulet was showcasing here is actually already a test in the broyden test suite.

Everything is green now (with simpler settings), so this is ready for review.

@zaccharieramzi zaccharieramzi marked this pull request as ready for review December 3, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant