Make test handing pedantic.

- Always super the setUp/tearDown - Ensure we cleanup (in tearDown) all fetcher related things created in setUp.
google · Dec 6, 2016 · f16f9c4 · f16f9c4
1 parent 44106c4
commit f16f9c4
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/Source/UnitTests/GTMReadMonitorInputStreamTest.m b/Source/UnitTests/GTMReadMonitorInputStreamTest.m
@@ -30,10 +30,14 @@ @implementation GTMReadMonitorInputStreamTest
 
 - (void)setUp {
   _monitoredData = [[NSMutableData alloc] init];
+
+  [super setUp];
 }
 
 - (void)tearDown {
   _monitoredData = nil;
+
+  [super tearDown];
 }
 
 - (void)testGTMReadMonitorInputStream {

diff --git a/Source/UnitTests/GTMSessionFetcherChunkedUploadTest.m b/Source/UnitTests/GTMSessionFetcherChunkedUploadTest.m
@@ -33,6 +33,12 @@ - (void)setUp {
   [super setUp];
 }
 
+- (void)tearDown {
+  _service = nil;
+
+  [super tearDown];
+}
+
 #pragma mark - Chunked Upload Fetch Tests
 
 - (void)testChunkedUploadTestBlock {

diff --git a/Source/UnitTests/GTMSessionFetcherFetchingTest.m b/Source/UnitTests/GTMSessionFetcherFetchingTest.m
@@ -35,10 +35,14 @@ @implementation GTMSessionFetcherBaseTest
 + (void)setUp {
   SubstituteUIApplication *app = [[SubstituteUIApplication alloc] init];
   [GTMSessionFetcher setSubstituteUIApplication:app];
+
+  [super setUp];
 }
 
 + (void)tearDown {
   [GTMSessionFetcher setSubstituteUIApplication:nil];
+
+  [super tearDown];
 }
 
 #endif  // GTM_BACKGROUND_TASK_FETCHING
@@ -59,6 +63,8 @@ - (void)setUp {
   _isServerRunning = (_testServer != nil);
   XCTAssertTrue(_isServerRunning,
                 @">>> http test server failed to launch; skipping fetcher tests\n");
+
+  [super setUp];
 }
 
 - (void)tearDown {
@@ -69,6 +75,8 @@ - (void)tearDown {
   _fetcherService = nil;
 
   [[GTMSessionFetcher staticCookieStorage] removeAllCookies];
+
+  [super tearDown];
 }
 
 #pragma mark -

diff --git a/Source/UnitTests/GTMSessionFetcherServiceTest.m b/Source/UnitTests/GTMSessionFetcherServiceTest.m
@@ -52,11 +52,15 @@ - (void)setUp {
 
   XCTAssertTrue(_isServerRunning,
                 @">>> http test server failed to launch; skipping service tests\n");
+
+  [super setUp];
 }
 
 - (void)tearDown {
   _testServer = nil;
   _isServerRunning = NO;
+
+  [super tearDown];
 }
 
 - (void)testFetcherService {