Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make [hostedDomain] and [listenPort] required in auth_io methods. #590

Closed
wants to merge 1 commit into from
Closed

Make [hostedDomain] and [listenPort] required in auth_io methods. #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions googleapis_auth/lib/auth_io.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ Future<AutoRefreshingAuthClient> clientViaApplicationDefaultCredentials({
Future<AutoRefreshingAuthClient> clientViaUserConsent(
ClientId clientId,
List<String> scopes,
PromptUserForConsent userPrompt, {
PromptUserForConsent userPrompt,
String hostedDomain,
int listenPort, {
Client? baseClient,
String? hostedDomain,
int listenPort = 0,
}) async {
var closeUnderlyingClient = false;
if (baseClient == null) {
Expand Down Expand Up @@ -174,9 +174,9 @@ Future<AutoRefreshingAuthClient> clientViaUserConsent(
Future<AutoRefreshingAuthClient> clientViaUserConsentManual(
ClientId clientId,
List<String> scopes,
PromptUserForConsentManual userPrompt, {
PromptUserForConsentManual userPrompt,
String hostedDomain, {
Client? baseClient,
String? hostedDomain,
}) async {
var closeUnderlyingClient = false;
if (baseClient == null) {
Expand Down Expand Up @@ -235,10 +235,10 @@ Future<AccessCredentials> obtainAccessCredentialsViaUserConsent(
ClientId clientId,
List<String> scopes,
Client client,
PromptUserForConsent userPrompt, {
String? hostedDomain,
int listenPort = 0,
}) =>
String hostedDomain,
int listenPort,
PromptUserForConsent userPrompt,
) =>
AuthorizationCodeGrantServerFlow(
clientId,
scopes,
Expand All @@ -264,9 +264,9 @@ Future<AccessCredentials> obtainAccessCredentialsViaUserConsentManual(
ClientId clientId,
List<String> scopes,
Client client,
PromptUserForConsentManual userPrompt, {
String? hostedDomain,
}) =>
String hostedDomain,
PromptUserForConsentManual userPrompt,
) =>
AuthorizationCodeGrantManualFlow(
clientId,
scopes,
Expand Down
3 changes: 2 additions & 1 deletion test_integration/lib/test_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,9 @@ Future<AccessCredentials> _credentials(
clientId,
scopes,
client,
'http://localhost',
8181,
_prompt,
listenPort: 8181,
);

credentialsFile.writeAsStringSync(prettyJsonEncode(credentials));
Expand Down
Loading