Skip to content

Commit

Permalink
chore: pin go to 1.17 to fix golangci-lint failing in 1.18 (#121)
Browse files Browse the repository at this point in the history
  • Loading branch information
Bobgy authored Apr 10, 2022
1 parent fd2d9ec commit 97c091f
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: Go
on:
push:
tags:
- v*
branches:
- master
- main
pull_request:
jobs:
build:
Expand All @@ -10,7 +15,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v2
with:
go-version: ^1.13
go-version: 1.17
- name: Check out code into the Go module directory
uses: actions/checkout@v2
- name: Get dependencies
Expand Down
14 changes: 13 additions & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
name: golangci-lint
on:
push:
tags:
- v*
branches:
- master
- main
pull_request:
permissions:
contents: read
jobs:
golangci:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v2
with:
# golangci-lint breaks on 1.18 for now: https://github.com/golangci/golangci-lint/issues/2649
# TODO(Bobgy): revert to ^1.17 for this and go.yml after it's fixed.
go-version: 1.17
- uses: actions/checkout@v2
- name: golangci-lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
# NOTICE: golangci-lint version should be the same as go.mod. When upgrading, also update go.mod by:
Expand Down

0 comments on commit 97c091f

Please sign in to comment.