Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce analysistest testdata convention. #278

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Introduce analysistest testdata convention. #278

merged 3 commits into from
Feb 3, 2021

Conversation

PurelyApplied
Copy link
Collaborator

@PurelyApplied PurelyApplied commented Feb 3, 2021 •
edited
Loading 

* Add Project Conventions to CONTRIBUTING.md and document this testdata convention.
* Move analysistest testdata from **/testdata/src/** to **/testdata/src/*_analysistest/**.
* Add go.mod for each *_analysistest
* Update relevant analysistest configurations.
* Update relevant *_test.go analysistest.Run package target strings.
* Update impacted imports.

Fixes #274
  • Running against a large codebase such as Kubernetes does not error out. (See DEVELOPING.md for instructions on how to do that.)
    • Currently failing on master with my current config. Need to revise after the FieldTags only accepting Value I think.
  • Appropriate changes to README CONTRIBUTING are included in PR

@PurelyApplied
Introduce analysistest testdata convention.
58dce56 
* Add Project Conventions to CONTRIBUTING.md and document this testdata convention.
* Move analysistest testdata from **/testdata/src/** to **/testdata/src/*_analysistest/**.
* Add go.mod for each *_analysistest
* Update relevant analysistest configurations.
* Update relevant *_test.go analysistest.Run package target strings.
* Update impacted imports.

Fixes google#274
@PurelyApplied PurelyApplied mentioned this pull request Feb 3, 2021
Open
@mlevesquedion
Copy link
Contributor

Why remove the "unnecessary" config element in this PR? This removal does not seem related to the other changes in the PR.

The config element is actually necessary, let's discuss on #279.

mlevesquedion
mlevesquedion reviewed Feb 3, 2021
View reviewed changes
Copy link
Contributor

@mlevesquedion mlevesquedion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the removal of the SourceManipulator config entry, which doesn't belong in this PR. Let's discuss in #279.

@mlevesquedion
Copy link
Contributor

Thank you for setting this up, this is great! 🎉

@PurelyApplied PurelyApplied merged commit 80f8749 into google:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlevesquedion mlevesquedion mlevesquedion approved these changes

@vinayakankugoyal vinayakankugoyal vinayakankugoyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PurelyApplied @mlevesquedion @vinayakankugoyal