Skip to content

Commit

Permalink
Fix the robot invocation of gapit trace.
Browse files Browse the repository at this point in the history
  • Loading branch information
pmuetschard committed Feb 15, 2019
1 parent 685d9b3 commit 5f46206
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/robot/trace/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,11 @@ func doTrace(ctx context.Context, action string, in *Input, store *stash.Client,
params := []string{
"trace",
"-out", tracefile.System(),
"-apk", subject.System(),
"-for", traceTime.String(),
"-disable-pcs",
"-observe-frames", strconv.Itoa(observeEveryNthFrame),
"-record-errors",
"-gapii-device", d.Instance().Serial,
"-serial", d.Instance().Serial,
"-api", in.GetHints().GetAPI(),
}

Expand All @@ -174,9 +173,11 @@ func doTrace(ctx context.Context, action string, in *Input, store *stash.Client,
defer func() {
file.Remove(obb)
}()
params = append(params, "-obb", obb.System())
// TODO fix this
// params = append(params, "-obb", obb.System())
return log.Errf(ctx, nil, "OBBs are currently not supported")
}
cmd := shell.Command(gapit.System(), params...)
cmd := shell.Command(gapit.System(), append(params, "apk:"+subject.System())...)
outBuf := &bytes.Buffer{}
errBuf := &bytes.Buffer{}
outputObj := &Output{}
Expand Down

0 comments on commit 5f46206

Please sign in to comment.