Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unreachable option in re2. #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed unreachable option in re2. #165

wants to merge 1 commit into from

Conversation

hghwng
Copy link

@hghwng hghwng commented Dec 29, 2019

data[0] << 16 + data[1] always results in 0b0000_0000_XXXX_XXXX, where XXXX_XXXX is the bits of data[1]. Therefore, f & 256 to f & 1024 are meaningless.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hghwng
Copy link
Author

hghwng commented Dec 29, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@hghwng
Copy link
Author

hghwng commented Jan 23, 2020

Any update?

@kcc
Copy link
Contributor

kcc commented Jan 24, 2020

Fun, good catch!
I am a bit reluctant to make this change because it's a benchmark, not a rel fuzz target that aims at finding the most of bugs. Changing it now means that we can't compare results before and after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants