-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[tint][ir][val] Reject discards outside of functions
While working on root causing the issue that led to this change I found some other related issues that should be addressed. They have been bundled up into this change: - Run() is modified so that later validation passes don't run if CheckStructureSoundness fails, since they assume that it passed. - ContainingFunction returns nullptr if the input is in the root block, which helps prevent ContainingEntryPoint from crashing in a very confusing way. Fixes: 382298307 Fixes: 382291447 Fixes: 382294238 Change-Id: Ibce8c5c52d6df960a54b0438cff7a07fe740c961 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/218174 Commit-Queue: dan sinclair <[email protected]> Auto-Submit: Ryan Harrison <[email protected]> Reviewed-by: dan sinclair <[email protected]>
- Loading branch information
Showing
2 changed files
with
45 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters