Skip to content

Commit

Permalink
[dawn] Remove Adreno suppression
Browse files Browse the repository at this point in the history
Changes to workgroup initalization mean that this suppression is no
longer required. The underlying adreno compiler bug still exists.

Bug: 42241359
Change-Id: I8fdd65030d2ea08455f8d6463ed79725a8e79d9b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/219994
Reviewed-by: James Price <[email protected]>
Commit-Queue: Peter McNeeley <[email protected]>
  • Loading branch information
Peter McNeeley authored and Dawn LUCI CQ committed Dec 20, 2024
1 parent 08d1d5b commit 88818a5
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions src/dawn/tests/end2end/ShaderAtomicTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@
#include "dawn/utils/WGPUHelpers.h"

// The motivation behind these tests is to investigate the failures in
// webgpu:shader,execution,expression,call,builtin,atomics,atomic* CTS for mobile gpus. The CAS
// emulation workaround is enough to avoid the issue on mali but still shows up as an issue on
// adreno.
// webgpu:shader,execution,expression,call,builtin,atomics,atomic* CTS for mobile gpus.

namespace dawn {
namespace {
Expand Down Expand Up @@ -103,10 +101,6 @@ class ShaderAtomicTests : public DawnTestWithParams<SubgroupsShaderTestsParams>
};

TEST_P(ShaderAtomicTests, WorkgroupAtomicArray) {
// TODO(crbug.com/42241359): Work in progress to resolve these tests mobile devices.
DAWN_SUPPRESS_TEST_IF(gpu_info::IsQualcomm_PCIAdreno6xx(GetParam().adapterProperties.vendorID,
GetParam().adapterProperties.deviceID));

// Suppression for Mali gpus.
DAWN_SUPPRESS_TEST_IF(gpu_info::IsARM(GetParam().adapterProperties.vendorID));

Expand Down

0 comments on commit 88818a5

Please sign in to comment.