Skip to content

Commit

Permalink
Add dawn-chromium-presubmit to all CLs
Browse files Browse the repository at this point in the history
Adds dawn-chromium-presubmit to all Dawn CLs and prevents reuse of
builds. This should help prevent cases of expectation conflicts
making it in.

Bug: 352816949
Change-Id: Ia3c39cbdd07b9015f3df106f4d5bb5d85080727b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/203595
Commit-Queue: Austin Eng <[email protected]>
Auto-Submit: Brian Sheedy <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Reviewed-by: Austin Eng <[email protected]>
  • Loading branch information
bsheedy-work authored and Dawn LUCI CQ committed Aug 23, 2024
1 parent 520a86a commit 704ba48
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
2 changes: 1 addition & 1 deletion infra/config/global/generated/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ config_groups {
}
builders {
name: "chromium/try/dawn-chromium-presubmit"
includable_only: true
disable_reuse: true
}
builders {
name: "chromium/try/dawn-try-linux-x64-intel-uhd770-rel"
Expand Down
19 changes: 10 additions & 9 deletions infra/config/global/main.star
Original file line number Diff line number Diff line change
Expand Up @@ -862,15 +862,6 @@ chromium_dawn_tryjob("win", "arm64")
chromium_dawn_tryjob("android", "arm")
chromium_dawn_tryjob("android", "arm64")

# TODO(crbug.com/352816949): Move this definition alongside the presubmit
# trybot and make it run on every CL once we confirm that it works as expected
# on Dawn CLs.
luci.cq_tryjob_verifier(
cq_group = "Dawn-CQ",
builder = "chromium:try/dawn-chromium-presubmit",
includable_only = True,
)

tricium_dawn_tryjob()

luci.cq_tryjob_verifier(
Expand Down Expand Up @@ -942,6 +933,16 @@ luci.cq_tryjob_verifier(
includable_only = True,
)

# This is separate from the "presubmit" builder for now since we do not want
# it branched yet.
# TODO(crbug.com/352816949): Decide whether or not we want this branched
# long-term.
luci.cq_tryjob_verifier(
cq_group = "Dawn-CQ",
builder = "chromium:try/dawn-chromium-presubmit",
disable_reuse = True,
)

# Views

luci.milo(
Expand Down

0 comments on commit 704ba48

Please sign in to comment.