Skip to content

Commit

Permalink
Add go tests to presubmit
Browse files Browse the repository at this point in the history
Change-Id: I2d56a463cecf0b1bcb96c51ae134c6fa07d87b21
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100560
Kokoro: Kokoro <[email protected]>
Reviewed-by: Ben Clayton <[email protected]>
Commit-Queue: Austin Eng <[email protected]>
  • Loading branch information
austinEng authored and Dawn LUCI CQ committed Sep 6, 2022
1 parent 8b4ed50 commit 185fd3d
Show file tree
Hide file tree
Showing 4 changed files with 86 additions and 1 deletion.
1 change: 0 additions & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ deps = {
},

'tools/golang': {
'condition': 'dawn_node',
'packages': [{
'package': 'infra/3pp/tools/go/${{platform}}',
'version': Var('dawn_go_version'),
Expand Down
28 changes: 28 additions & 0 deletions go_presubmit_support.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Copyright 2022 The Dawn & Tint Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

def RunGoTests(input_api, output_api):
results = []
try:
go = input_api.os_path.join(input_api.change.RepositoryRoot(), "tools",
"golang", "bin", "go")
if input_api.is_windows:
go += '.exe'
input_api.subprocess.check_call_out([go, "test", "./..."],
stdout=input_api.subprocess.PIPE,
stderr=input_api.subprocess.PIPE,
cwd=input_api.PresubmitLocalPath())
except input_api.subprocess.CalledProcessError as e:
results.append(output_api.PresubmitError('%s' % (e, )))
return results
29 changes: 29 additions & 0 deletions src/dawn/node/PRESUBMIT.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Copyright 2022 The Dawn & Tint Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import sys

USE_PYTHON3 = True


def _DoCommonChecks(input_api, output_api):
sys.path += [input_api.change.RepositoryRoot()]

from go_presubmit_support import RunGoTests

return RunGoTests(input_api, output_api)


CheckChangeOnUpload = _DoCommonChecks
CheckChangeOnCommit = _DoCommonChecks
29 changes: 29 additions & 0 deletions tools/PRESUBMIT.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Copyright 2022 The Dawn & Tint Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import sys

USE_PYTHON3 = True


def _DoCommonChecks(input_api, output_api):
sys.path += [input_api.change.RepositoryRoot()]

from go_presubmit_support import RunGoTests

return RunGoTests(input_api, output_api)


CheckChangeOnUpload = _DoCommonChecks
CheckChangeOnCommit = _DoCommonChecks

0 comments on commit 185fd3d

Please sign in to comment.