Skip to content

Commit

Permalink
Add googletest to python deps script
Browse files Browse the repository at this point in the history
Without this dependency, automated builds will error since the third_party/googletest folder does not have a CMakeLists.txt or is required somewhere and should not be.

This is an imported pull request from
#20

GITHUB_PR_HEAD_SHA=3c4eed2eb3d1fa06ffdea2eb7be63529269a1b05
ORIGINAL_AUTHOR=MichealReed <[email protected]>
GitOrigin-RevId: f262db9
Change-Id: Ifde416b3c4bd016024d9993aab777a697e2f6128
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/201818
Commit-Queue: Austin Eng <[email protected]>
Reviewed-by: Austin Eng <[email protected]>
  • Loading branch information
MichealReed authored and Dawn LUCI CQ committed Aug 16, 2024
1 parent 59b544b commit 0552b21
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions tools/fetch_dawn_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
action='store_true',
default=False,
help="""
Fetch dependencies needed for testing
Deprecated: Test dependencies are now always included.
""")


Expand All @@ -108,17 +108,16 @@ def main(args):
'third_party/markupsafe',
'third_party/glslang/src',
'third_party/google_benchmark/src',
'third_party/googletest',
'third_party/spirv-headers/src',
'third_party/spirv-tools/src',
'third_party/vulkan-headers/src',
'third_party/vulkan-loader/src',
'third_party/vulkan-utility-libraries/src',
]

if args.use_test_deps:
required_submodules += [
'third_party/googletest',
]
log("""WARNING: --use-test-deps argument deprecated.
Test dependencies are now always included.""")

root_dir = Path(args.directory).resolve()

Expand Down

0 comments on commit 0552b21

Please sign in to comment.