Exclude original_data
field from PartialEq
comparison
#102
+10
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
original_data
is not required to be set, used/initialised only in limited number of cases.So to be still be consistent in comparison operation, I am suggesting to exclude
original_data
field from comparing implementation.As a result it eliminates inconvenience to alway keep this field either empty or initialised to be able to properly compare two
ProtectedHeaders
instances at this moment.