build: fix mingw-w64 builds with ASM enabled #32
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
It's a trivial patch fixing a build regression. Please accept it as-is or as an issue report. Also feel free to commit via a CLA-blessed user. |
1 task
Fixes: ``` ld.lld: error: undefined symbol: fiat_p256_adx_mul >>> referenced by libcrypto.a(bcm.o):(fiat_p256_mul) ld.lld: error: undefined symbol: fiat_p256_adx_sqr >>> referenced by libcrypto.a(bcm.o):(fiat_p256_square) ``` All Windows builds use NASM. NASM sources miss the implementation for these functions. Yet they are referenced for all GCC x86_64 builds, which includes mingw-64. Disable these references for mingw-64 to make the build succeed.
vszakats
force-pushed
the
fix-asm-mingw-w64
branch
from
7697fa5
to
09ce163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
All Windows builds use NASM. NASM sources miss the implementation for
these functions. Yet they are referenced for all GCC x86_64 builds,
which includes mingw-64.
Disable these references for mingw-64 to make the build succeed.