feat: highlight text in workspace search on open and add backwards nav #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Aug 6, 2024
riknoll
force-pushed
the
workspace-search-fix
branch
from
cb864d9
to
adae5ad
Compare
|
@BeksOmega ran prettier! |
|
Thank you for contributing this @riknoll ! It should get published automatically on Thursday ~10AM PT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2438
Proposed Changes
Tweaks the behavior of the workspace search plugin:
Reason for Changes
See attached issue
Test Coverage
I tested both changes manually.
I attempted to add unit tests for the selection fix, but it seems like whatever headless DOM library the blockly test runner is using doesn't have great support for the
document.getSelection()API.Documentation
None
Additional Information
None