Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move away from using innerHTML #2321

Closed
wants to merge 1 commit into from

Conversation

Shivam7-1
Copy link
Contributor

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML. Always be cautious when dealing with user input or dynamic content to prevent security risks.

@Shivam7-1 Shivam7-1 requested a review from a team as a code owner April 14, 2024 06:53
@Shivam7-1 Shivam7-1 requested review from maribethb and removed request for a team April 14, 2024 06:53
Copy link

conventional-commit-lint-gcf bot commented Apr 14, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@Shivam7-1
Copy link
Contributor Author

Hi @maribethb Could You Please Review this PR
Thanks

@Shivam7-1
Copy link
Contributor Author

Hi @maribethb Could You Please Review this PR
Thanks

@maribethb
Copy link
Contributor

Hi @Shivam7-1, this plugin was recently converted to TypeScript so this PR needs to be rebased and the change should be made against the equivalent ts file now instead.

Also, we use conventional commits in order to generate good release notes. Could you please follow these instructions to use conventional commits?

@Shivam7-1
Copy link
Contributor Author

Hi @maribethb Thanks For Reviewing
I think I had Committed in Lastest Repo Could You Please Review Above PR again
Reagrds

@NeilFraser NeilFraser requested review from NeilFraser and removed request for maribethb April 19, 2024 17:22
@NeilFraser NeilFraser assigned NeilFraser and unassigned maribethb Apr 19, 2024
@NeilFraser
Copy link
Contributor

This is actually a good change. Though as @maribethb states, it collides with recent commits, so it needs to be rebased. Also, instead of .innerText, one should (almost) always use .textContent.

@NeilFraser NeilFraser changed the title Update field-bitmap.js DOM text reinterpreted as HTML fix: Move away from using innerHTML Apr 20, 2024
@Shivam7-1 Shivam7-1 closed this Apr 20, 2024
@Shivam7-1 Shivam7-1 reopened this Apr 20, 2024
@Shivam7-1
Copy link
Contributor Author

Hi @maribethb I Had Done Changes Accordingly and Updated My Branch Could Please Review This PR

Thanks

1 similar comment
@Shivam7-1
Copy link
Contributor Author

Hi @maribethb I Had Done Changes Accordingly and Updated My Branch Could Please Review This PR

Thanks

@Shivam7-1
Copy link
Contributor Author

Hi @maribethb Could You Please Review This PR
Thanks

@maribethb
Copy link
Contributor

@NeilFraser owns this PR review now. Thanks!

@NeilFraser
Copy link
Contributor

This PR is just a whitespace change. I don't think that's what you are looking for.

@Shivam7-1
Copy link
Contributor Author

Hi @NeilFraser Thanks For Reviewing
As I just check the improvement which I want to done it's already done week ago
And After Rebase the Changes is not Required
As I checked

Thanks

@BeksOmega
Copy link
Contributor

Closing as already completed.

@BeksOmega BeksOmega closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants