Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow const variables to have UPPER_CASE names #2300

Merged

Conversation

rachel-fenichel
Copy link
Collaborator

@rachel-fenichel rachel-fenichel commented Apr 2, 2024

The basics

The details

Reason for change

Necessary for block definition change.

Fixes #2298

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner April 2, 2024 17:43
@rachel-fenichel rachel-fenichel requested review from maribethb and removed request for a team April 2, 2024 17:43
Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THE_SHOUTIEST_CASE

@BeksOmega
Copy link
Contributor

oh whoops didn't realize this was for mb

@rachel-fenichel rachel-fenichel merged commit 2586fe6 into google:master Apr 2, 2024
9 checks passed
@rachel-fenichel rachel-fenichel deleted the eslint-naming-convention branch April 2, 2024 17:47
gonfunko pushed a commit to gonfunko/blockly-samples that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint config disallows CONSTANT_CASE
3 participants