fix(migration): Ignore non-renamed modules (#2309)

* fix(migration): Ignore non-renamed modules + add a test for this. * chore(migration): Remove log statement
google · Apr 5, 2024 · 8c8b04d · 8c8b04d
1 parent d9caf5d
commit 8c8b04d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/plugins/migration/bin/rename.js b/plugins/migration/bin/rename.js
@@ -192,7 +192,9 @@ class VersionRenamer {
       //   moduleA.exportA -> moduleC.exportB
       // And we performed the module rename first, we wouldn't be able to detect
       // the export rename.
-      this.renamings_.push({old: oldModulePath, new: newModulePath});
+      if (newModulePath !== oldModulePath) {
+        this.renamings_.push({old: oldModulePath, new: newModulePath});
+      }
     }
   }
 

diff --git a/plugins/migration/test/rename.mocha.js b/plugins/migration/test/rename.mocha.js
@@ -17,6 +17,10 @@ suite('Rename', function () {
   test('a javascript program with multiple renames works correctly', function () {
     const database = {
       '1.0.0': [
+        {
+          oldName: 'Blockly',
+          exports: {}
+        },
         {
           oldName: 'Blockly.moduleA',
           newName: 'Blockly.newModuleA',