Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cases: reset devices one by one #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion avatar/cases/host_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ def teardown_class(self) -> None:

@avatar.asynchronous
async def setup_test(self) -> None: # pytype: disable=wrong-arg-types
await asyncio.gather(self.dut.reset(), self.ref.reset())
# NOTE: this used to be performed in parallel but can lead to flakiness
# (eg. the DUT has re-connect logics and REF reset too fast).
await self.dut.reset()
await self.ref.reset()

@avatar.parameterized(
(DISCOVERABLE_LIMITED,),
Expand Down
5 changes: 4 additions & 1 deletion avatar/cases/le_host_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ def teardown_class(self) -> None:

@avatar.asynchronous
async def setup_test(self) -> None: # pytype: disable=wrong-arg-types
await asyncio.gather(self.dut.reset(), self.ref.reset())
# NOTE: this used to be performed in parallel but can lead to flakiness
# (eg. the DUT has re-connect logics and REF reset too fast).
await self.dut.reset()
await self.ref.reset()

@avatar.parameterized(
*itertools.product(
Expand Down
5 changes: 4 additions & 1 deletion avatar/cases/le_security_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ async def test_le_pairing(
raise signals.TestSkip('CTKD requires Security Level 4')

# Factory reset both DUT and REF devices.
await asyncio.gather(self.dut.reset(), self.ref.reset())
# NOTE: this used to be performed in parallel but can lead to flakiness
# (eg. the DUT has re-connect logics and REF reset too fast).
await self.dut.reset()
await self.ref.reset()

# Override REF IO capability if supported.
if isinstance(self.ref, BumblePandoraDevice):
Expand Down
5 changes: 4 additions & 1 deletion avatar/cases/security_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,10 @@ async def test_ssp(
raise signals.TestSkip('CTKD cases must be conducted under Security Level 4')

# Factory reset both DUT and REF devices.
await asyncio.gather(self.dut.reset(), self.ref.reset())
# NOTE: this used to be performed in parallel but can lead to flakiness
# (eg. the DUT has re-connect logics and REF reset too fast).
await self.dut.reset()
await self.ref.reset()

# Override REF IO capability if supported.
if isinstance(self.ref, BumblePandoraDevice):
Expand Down