Support optional image downloading with CAS in fetch-cvd #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfeng579
requested review from
Databean,
rmuthiah,
jemoreira and
ser-io
as code owners
jemoreira
reviewed
Nov 26, 2024
There was a problem hiding this comment.
I'd like to see how HardlinkRecursively is going to be used before approving it. Please create a single PR with several commits: one for adding the function and as many as you need for the actual functionality you're trying to implement.
My concern with HardlinkRecursively is that it seems to be trying to implement "hardlink for directories", which most of the time can be done by just using a symbolic link.
frankfeng579
force-pushed
the
hardlink
branch
13 times, most recently
from
71c3f8d to
44209a5
Compare
frankfeng579
changed the title
frankfeng579
force-pushed
the
hardlink
branch
5 times, most recently
from
2f3dde2 to
e40dfb3
Compare
2chiefk
approved these changes
Dec 1, 2024
|
@jemoreira, as suggested, added 2 more commits to the PR and that should be all for CAS downloading support in cvd. |
|
Don't do "merge commits", rebase the |
jemoreira
reviewed
Dec 2, 2024
frankfeng579
force-pushed
the
hardlink
branch
from
afdef99 to
08206a9
Compare
jemoreira
reviewed
Dec 2, 2024
frankfeng579
force-pushed
the
hardlink
branch
2 times, most recently
from
349cc22 to
d4987be
Compare
Databean
approved these changes
Dec 4, 2024
base/cvd/cuttlefish/host/commands/cvd/unittests/fetch/fetch_cvd_parser_test.cpp
Outdated
Show resolved
Hide resolved
Also: fixed a memory leak in IsDirectoryEmpty.
Update android_build_api/caching_build_api to support downloading device images using CAS.
The support of CAS downloading is optional and can be enable with command line arguments.
frankfeng579
force-pushed
the
hardlink
branch
from
d4987be to
90ee21f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.