-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce isolation in artifacts.yaml #749
Open
c0rv4x
wants to merge
17
commits into
google:main
Choose a base branch
from
c0rv4x:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0f8f3c3
Introduce isolation in artifacts.yaml
c0rv4x 437ed23
Merge branch 'main' into patch-1
jemoreira 18f2845
Merge branch 'main' into patch-1
jemoreira 7b34702
Isolate docker build images
a2252f2
Merge branch 'main' into patch-1
c0rv4x f66ad16
Remove unnecessary sudo in github ci/cd
963ade5
Merge branch 'patch-1' of github.com:c0rv4x/android-cuttlefish into p…
bc1f495
aa
adapted-croc e4b7986
aa
d8adbbb
aa
861ed12
aa:wq
random-500-random 1a54d71
aa
invalid-email-address ed655f4
aa
github-info 403ac71
aa
invalid-email-address f5f9a55
Make PLATFORM variable set to local arch by default
adapted-croc 13e8fb3
Remove arch being set in buildx
adapted-croc b763841
Add wget to github ci/cd build
adapted-croc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,28 @@ | ||
#!/usr/bin/env bash | ||
|
||
# This shell script exists for building docker image. | ||
# Docker image includes HO(Host Orchestrator) inside, | ||
# so it could execute CF instance with API in HO. | ||
# This shell script exists for building Docker image using Docker Buildx. | ||
# The image includes HO (Host Orchestrator) inside, so it can execute CF instance with API in HO. | ||
|
||
script_location=`realpath -s $(dirname ${BASH_SOURCE[0]})` | ||
android_cuttlefish_root_dir=$(realpath -s $script_location/..) | ||
set -e | ||
|
||
script_location=$(realpath -s $(dirname "${BASH_SOURCE[0]}")) | ||
android_cuttlefish_root_dir=$(realpath -s "$script_location/..") | ||
|
||
if [[ "$1" == "" ]]; then | ||
tag=cuttlefish-orchestration | ||
tag="cuttlefish-orchestration" | ||
else | ||
tag=$1 | ||
tag="$1" | ||
fi | ||
|
||
# Build docker image | ||
pushd $android_cuttlefish_root_dir | ||
docker build \ | ||
# Set up Docker Buildx if not already set up | ||
docker buildx create --use || true | ||
|
||
# Build the Docker image using Buildx for x86_64 and arm64 platforms | ||
pushd "$android_cuttlefish_root_dir" | ||
docker buildx build \ | ||
--force-rm \ | ||
--no-cache \ | ||
-f docker/Dockerfile \ | ||
-t $tag \ | ||
. | ||
-t "$tag" \ | ||
--load . | ||
popd |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have another job
export-docker-image-x86_64
above. If it does for arm64, why don't we do it for x86_64 as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x86_64 is run on Github-hosted runner, so it would be unnecessary