Simplify RequestWithStdio and rename it as CommandRequest #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullIo has to open /dev/null, while Stdio just copies std::cout and std::cin.
The translator has been disabled so this is mostly no-op. This was the This change makes acloud create always verbose, but eliminates the last use of NullIo, which allows for a greater simplification of the RequestWithStdio class.
It's not used.
It's always set to CurrentDirectory()
It's always set to standard IO
Also rename the server_client.* files as there are no servers and clients anymore.
ser-io
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.