Replace conv-hwc yaml with table header #7445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharlet
approved these changes
Nov 12, 2024
RahulSundarMCW
force-pushed
the
conv-hwc
branch
from
351eb1c to
6d39a08
Compare
dsharlet
approved these changes
Nov 12, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
-- 5d5cd76 by RahulSudarMCW <[email protected]>: Replace conv-hwc yaml with table header -- ad05494 by RahulSudarMCW <[email protected]>: Remove 'conv-hwc-microkernel-tester.h' -- 6d39a08 by RahulSudarMCW <[email protected]>: Declare microkernal to use table header -- 93d6323 by RahulSudarMCW <[email protected]>: Resolve failed checks FUTURE_COPYBARA_INTEGRATE_REVIEW=#7445 from RahulSundarMCW:conv-hwc 93d6323 PiperOrigin-RevId: 695826548
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
-- 5d5cd76 by RahulSudarMCW <[email protected]>: Replace conv-hwc yaml with table header -- ad05494 by RahulSudarMCW <[email protected]>: Remove 'conv-hwc-microkernel-tester.h' -- 6d39a08 by RahulSudarMCW <[email protected]>: Declare microkernal to use table header -- 93d6323 by RahulSudarMCW <[email protected]>: Resolve failed checks FUTURE_COPYBARA_INTEGRATE_REVIEW=#7445 from RahulSundarMCW:conv-hwc 93d6323 PiperOrigin-RevId: 695826548
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
-- 5d5cd76 by RahulSudarMCW <[email protected]>: Replace conv-hwc yaml with table header -- ad05494 by RahulSudarMCW <[email protected]>: Remove 'conv-hwc-microkernel-tester.h' -- 6d39a08 by RahulSudarMCW <[email protected]>: Declare microkernal to use table header -- 93d6323 by RahulSudarMCW <[email protected]>: Resolve failed checks FUTURE_COPYBARA_INTEGRATE_REVIEW=#7445 from RahulSundarMCW:conv-hwc 93d6323 PiperOrigin-RevId: 695826548
RahulSundarMCW
force-pushed
the
conv-hwc
branch
2 times, most recently
from
edd8c87 to
45f3170
Compare
RahulSundarMCW
force-pushed
the
conv-hwc
branch
from
45f3170 to
861cefe
Compare
dsharlet
reviewed
Nov 22, 2024
| TEST(ukernel, input_width_eq) \ | ||
| { \ | ||
| auto tester = ConvHWCMicrokernelTester() \ |
There was a problem hiding this comment.
TEST_REQUIRES_ARCH_FALGS(arch_flags)
Also, these macros are really big. Can you put these in helper functions, so the macro is smaller? Compiler errors and such in macros are a pain to work with.
There was a problem hiding this comment.
Could you please provide further clarification, as we are a bit unclear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.