Replace lut32norm yaml with table header #7444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharletg
reviewed
Nov 8, 2024
test/u8-lut32norm.cc
Outdated
| // | ||
| // Auto-generated file. Do not edit! | ||
| // Specification: test/u8-lut32norm.yaml | ||
| // Generator: tools/generate-lut-norm-test.py | ||
|
|
||
| #include <cstddef> | ||
|
|
||
| #include <gtest/gtest.h> | ||
| #include "xnnpack/lut.h" | ||
| #include "lut-norm-microkernel-tester.h" |
There was a problem hiding this comment.
Remove this file and move the contents here (if it's the only use).
RahulSundarMCW
force-pushed
the
lut32norm
branch
from
2bd79bf to
fb85890
Compare
dsharletg
approved these changes
Nov 11, 2024
dsharlet
approved these changes
Nov 12, 2024
RahulSundarMCW
force-pushed
the
lut32norm
branch
from
a25e8b0 to
d1db73a
Compare
|
I think this one is failing the import/copybara step due to a merge conflict, can you try merging master? |
RahulSundarMCW
force-pushed
the
lut32norm
branch
from
a978818 to
a7253dd
Compare
RahulSundarMCW
force-pushed
the
lut32norm
branch
from
d1db73a to
9d58ad6
Compare
Yesterday, we resolved the merge conflicts through the web editor, but since that option wasn't available today, so handled them locally and pushed the updates. I hope this works smoothly, but please let me know if any further adjustments are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.