Skip to content

Commit

Permalink
Fix for QD8 GEMM AVXVNNI tests
Browse files Browse the repository at this point in the history
- Add unsigned-inputs: True

PiperOrigin-RevId: 704521275
  • Loading branch information
fbarchard authored and xnnpack-bot committed Dec 10, 2024
1 parent fde3571 commit 1f66b6a
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/qd8-f16-qc4w-gemm-minmax-4.cc
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ std::vector<GemmTestParams> CreateTests1(
/*adj_k_block=*/16,
/*mr=*/8, /*nr=*/8, /*kr=*/8, /*sr=*/1,
/*is_igemm=*/false,
/*unsigned_inputs=*/false,
/*unsigned_inputs=*/true,
[](GemmMicrokernelTester& tester) {
tester.Test(xnn_qd8_f16_qc4w_gemm_minmax_ukernel_8x8c8__avxvnni_prfm,
xnn_init_f16_qc4w_minmax_scalar_params,
Expand Down
1 change: 1 addition & 0 deletions test/qd8-f16-qc4w-gemm-minmax.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,7 @@
init: xnn_init_f16_qc4w_minmax_scalar_params
pack: xnn_pack_qs8_qc4w_gemm_goi_w
k-block: 16
unsigned-inputs: True

# x86 AVX2
- name: xnn_qd8_f16_qc4w_gemm_minmax_ukernel_1x8c8__avx2
Expand Down
2 changes: 1 addition & 1 deletion test/qd8-f16-qc8w-gemm-minmax-4.cc
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,7 @@ std::vector<GemmTestParams> CreateTests1(
/*adj_k_block=*/16,
/*mr=*/8, /*nr=*/8, /*kr=*/8, /*sr=*/1,
/*is_igemm=*/false,
/*unsigned_inputs=*/false,
/*unsigned_inputs=*/true,
[](GemmMicrokernelTester& tester) {
tester.Test(xnn_qd8_f16_qc8w_gemm_minmax_ukernel_8x8c8__avxvnni_prfm,
xnn_init_f16_minmax_scalar_params,
Expand Down
1 change: 1 addition & 0 deletions test/qd8-f16-qc8w-gemm-minmax.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@
init: xnn_init_f16_minmax_scalar_params
pack: xnn_pack_qs8_gemm_goi_w
k-block: 16
unsigned-inputs: True

# x86 AVX2
- name: xnn_qd8_f16_qc8w_gemm_minmax_ukernel_1x8c8__avx2
Expand Down
2 changes: 1 addition & 1 deletion test/qd8-f32-qc8w-igemm-minmax.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,7 @@ INSTANTIATE_TEST_SUITE_P(
/*adj_k_block=*/16,
/*mr=*/8, /*nr=*/8, /*kr=*/8, /*sr=*/1,
/*is_igemm=*/true,
/*unsigned_inputs=*/false,
/*unsigned_inputs=*/true,
[](GemmMicrokernelTester& tester) {
tester.Test(xnn_qd8_f32_qc8w_igemm_minmax_ukernel_8x8c8__avxvnni_prfm,
xnn_init_f32_minmax_scalar_params,
Expand Down
1 change: 1 addition & 0 deletions test/qd8-f32-qc8w-igemm-minmax.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,7 @@
init: xnn_init_f32_minmax_scalar_params
pack: xnn_pack_qs8_conv_goki_w
k-block: 16
unsigned-inputs: True

# WAsm
- name: xnn_qd8_f32_qc8w_igemm_minmax_ukernel_1x2__wasm
Expand Down

0 comments on commit 1f66b6a

Please sign in to comment.