[DO NOT MERGE] Attempt and info for merging master into macOS build #39
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
thisiscam
changed the title
| @@ -23,3 +23,5 @@ build --cxxopt="-DNDEBUG" | |||
|
|
|||
| # Options from ./configure | |||
| try-import %workspace%/.reverb.bazelrc | |||
|
|
|||
| build --features=-supports_dynamic_linker | |||
There was a problem hiding this comment.
This was necessary due to bazelbuild/bazel#4341.
I also had to use bazel==4.1.0rc04 -- I tried 4.0.0 (the latest homebrew version) and that didn't work for me for some reason.
| deps = ["{}_static".format(name)], | ||
| linkshared = 1, | ||
| **kwargs | ||
| ) | ||
| native.cc_library( | ||
| name = name, | ||
| hdrs = gen_hdrs, | ||
| srcs = ["lib{}.so".format(name)], |
There was a problem hiding this comment.
These lib -> libxxx changes was necessary to let my Bazel not complain about conflicting names.
Inspired by bazelbuild/bazel#4341 (comment).
reverb/cc/platform/default/repo.bzl
Outdated
| @@ -103,7 +103,7 @@ def _find_python_solib_path(repo_ctx): | |||
| .format(exec_result.stderr)) | |||
|
|
|||
| if is_darwin(repo_ctx): | |||
| basename = "lib{}m.dylib".format(version) | |||
|
@googlebot I consent |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
The (excerpt of log) The error you are experiencing (Symbol not found) is probably due to the version mismatch between reverb and tensorflow. You should use tf-nightly or any recent versions. |
Hi,
I would like to share my progress in trying to merge the latest master into the macOS build #24 developed by @lifeiteng.
The merge went smoothly; however, there were a few places that I needed to fix/hack, in order to build successfully.
I will comment in my commit below for the details about the hacks.
Hopefully, these will be somewhat useful info for folks to merge #24 into master.
Currently this fails 10 tests, all of them of the form:
-- which I assume are caused by incompatible TensorFlow library versions.