Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): drop MANIFEST.in #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(build): drop MANIFEST.in #298

wants to merge 1 commit into from

Conversation

SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented Nov 16, 2024 •
edited
Loading

This PR drops the MANIFEST.in file in favour of tool.setuptools.package-data in pyproject.toml.

I verified the changes by building the package and asserting py.typed is in the distribution:

> python -m build
> tar -tzf dist/kfac_jax-0.0.6.tar.gz | grep "py.typed"

kfac_jax-0.0.6/kfac_jax/py.typed

Request for Review: @fabianp

fabianp
fabianp approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@fabianp fabianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Saurav!

@fabianp
Copy link
Member

fabianp commented Nov 20, 2024

oh, but I'm not a maintainer of this repo! please assign one of the maintainers, such as @botev or @james-martens

@SauravMaheshkar
Copy link
Contributor Author

Request for Review: @botev

PS: I'm not sure if kfac-jax is accepting external contributions yet but I figured I'd try again since #94 got merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianp fabianp fabianp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SauravMaheshkar @fabianp