Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify logic using req #3

Merged
merged 5 commits into from
Aug 24, 2024
Merged

Simplify logic using req #3

merged 5 commits into from
Aug 24, 2024

Conversation

goofansu
Copy link
Owner

@goofansu goofansu commented Aug 24, 2024 •
edited
Loading

Breaking changes

Updates

  • Simplify logic using req
  • Test using Req.Test
  • Allow users to pass req_options (such as max_redirects)

Config req_options

config :ogp,
  req_options: [
    max_retries: 5,
    retry_delay: 1000,
  ]

See https://hexdocs.pm/req/0.5.6/Req.html#new/1-options for the full options list.

@goofansu goofansu marked this pull request as draft August 24, 2024 07:30
@goofansu goofansu force-pushed the use-req branch 2 times, most recently from bb47798 to a512f9c Compare August 24, 2024 08:51
@goofansu goofansu marked this pull request as ready for review August 24, 2024 17:40
@goofansu goofansu merged commit bd336a9 into main Aug 24, 2024
2 checks passed
@goofansu goofansu deleted the use-req branch August 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@goofansu