Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: form submit issue on Brave browser #1468

Merged
merged 3 commits into from
Dec 25, 2024
Merged

fix: form submit issue on Brave browser #1468

merged 3 commits into from
Dec 25, 2024

Conversation

barry800414
Copy link
Contributor

@barry800414 barry800414 commented Dec 22, 2024 •
edited
Loading

Close #1465

這個 PR 是？

  • fix the issue that user cannot submit form on Brave browser

我應該如何手動測試？

  • use chrome browser, submit interview / salary / work successfully, check the API request body contains ga_user_pseudo_id
  • use brave browser, submit interview / salary / work successfully

@barry800414 barry800414 requested a review from a team December 22, 2024 15:28
peteranny
peteranny approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@peteranny peteranny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly

@mark86092 mark86092 merged commit 24e1eb4 into master Dec 25, 2024
10 checks passed
@mark86092 mark86092 deleted the fix/form-submit-on-brave branch December 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteranny peteranny peteranny approved these changes

@mark86092 mark86092 mark86092 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brave 瀏覽器無法正常上傳表單
3 participants
@barry800414 @mark86092 @peteranny