Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 移除面試整體評分 #1461

Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat: 移除面試整體評分 #1461

merged 2 commits into from
Dec 20, 2024

Conversation

peteranny
Copy link
Contributor

Close #1457

這個 PR 是?

移除「為這次面試打個分數」

也一併修理 TextArea 的 prop validation

我應該如何手動測試?

@peteranny peteranny self-assigned this Dec 8, 2024
@peteranny peteranny changed the base branch from master to dev December 8, 2024 18:04
@peteranny peteranny marked this pull request as ready for review December 8, 2024 18:04
@peteranny peteranny requested a review from a team December 8, 2024 18:05
@mark86092 mark86092 changed the base branch from dev to dev2 December 10, 2024 16:53
@mark86092
Copy link
Contributor

https://www-dev2.goodjob.life/ ready 了,推到 dev2 分支就會自動 deploy 上去

@peteranny
Copy link
Contributor Author

感謝 @mark86092 🙏🏼

Copy link
Contributor

@barry800414 barry800414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,不過後端 API 改動後,這個固定 5 分的邏輯要從前端拔掉

@peteranny peteranny merged commit c110506 into dev2 Dec 20, 2024
8 checks passed
@peteranny peteranny deleted the feat/interview-aspects branch December 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] 更新面試經驗表單:移除面試滿意度
3 participants