Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 在面試表單放 error log #1456

Merged
merged 7 commits into from
Dec 9, 2024
Merged

chore: 在面試表單放 error log #1456

merged 7 commits into from
Dec 9, 2024

Conversation

peteranny
Copy link
Contributor

@peteranny peteranny commented Dec 1, 2024

#1455

這個 PR 是?

在可能無回應處打 log

Screenshots

截圖 2024-12-02 凌晨12 43 08

我應該如何手動測試?

  • 沒辦法真的測試,但可以把 pushErrorNotificationAndRollbarAndThrowError 放在一般 render 處測試的確會打 rollbar 和顯示 toast

@peteranny peteranny self-assigned this Dec 1, 2024
@peteranny peteranny marked this pull request as ready for review December 1, 2024 16:44
@peteranny peteranny requested a review from a team December 1, 2024 16:44
@peteranny peteranny changed the title chore: 在面試表單可能出錯處埋 log chore: 在面試表單放 error log Dec 2, 2024
@peteranny peteranny requested a review from barry800414 December 3, 2024 15:44
@peteranny peteranny requested a review from mark86092 December 8, 2024 17:40
@peteranny peteranny merged commit 9eaa137 into master Dec 9, 2024
8 checks passed
@peteranny peteranny deleted the chore/log-error branch December 9, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants