feat: add ReportDialog #1453
Open
feat: add ReportDialog #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteranny
reviewed
Nov 18, 2024
|
Hi @YongChenSu please help take a look at @peteranny 's comment. |
|
Single experience detail page will crash Please ensure below pages works before review
|
|
Hi @YongChenSu 這個再麻煩你修復了 |
peteranny
reviewed
Dec 30, 2024
| @@ -70,6 +73,13 @@ const ReactionZone = ({ experienceId, onClickMsgButton }) => { | |||
| > | |||
| 留言 | |||
| </ReactionButton> | |||
| <ReactionButton className={styles.report}> | |||
There was a problem hiding this comment.
這裡沒有傳 Icon 應該會需要改 propType 為 optional
https://github.com/goodjoblife/GoodJobShare/pull/1453/files#diff-d9f8e21796d3ada3513ae9ce06a3175f32e1f7a2d106efe3fb8ed2f29f85019fL25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這個 PR 是？
Screenshots
我應該從何看起？
先給出 UI，功能實作中，回報數量先給預設常數。
Questions:
串 API 中
已驗證，
createSalaryWorkTimeReport、createExperienceReport、query experience功能正常。但無法
query salaryWorkTime，有可能是 query 下錯，詢問中，討論串連結我應該如何手動測試？
起 local