Merge pull request #5616 from gooddata/nen-lx-655-databricks-client

feat: extend DS with databrick credentials
gooddata · Nov 28, 2024 · fb8951f · fb8951f
2 parents 97890ad + e385072
commit fb8951f
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/libs/sdk-backend-tiger/api/sdk-backend-tiger.api.md b/libs/sdk-backend-tiger/api/sdk-backend-tiger.api.md
@@ -166,6 +166,8 @@ export interface IDataSourceConnectionInfo {
     // (undocumented)
     cacheStrategy?: IDataSourceCacheStrategy;
     // (undocumented)
+    clientId?: string;
+    // (undocumented)
     decodedParameters?: Array<DataSourceParameter> | null;
     // (undocumented)
     id: string;
@@ -198,6 +200,10 @@ export interface IDataSourcePatchRequest {
     // (undocumented)
     cacheStrategy?: IDataSourceCacheStrategy;
     // (undocumented)
+    clientId?: string | null;
+    // (undocumented)
+    clientSecret?: string | null;
+    // (undocumented)
     id: string;
     // (undocumented)
     name?: string;
@@ -226,6 +232,10 @@ export type IDataSourcePermission = "MANAGE" | "USE";
 
 // @internal (undocumented)
 export interface IDataSourceTestConnectionRequest {
+    // (undocumented)
+    clientId?: string;
+    // (undocumented)
+    clientSecret?: string;
     // (undocumented)
     parameters?: Array<DataSourceParameter>;
     // (undocumented)
@@ -262,6 +272,10 @@ export interface IDataSourceUpsertRequest {
     // (undocumented)
     cacheStrategy?: IDataSourceCacheStrategy;
     // (undocumented)
+    clientId?: string;
+    // (undocumented)
+    clientSecret?: string;
+    // (undocumented)
     id: string;
     // (undocumented)
     name: string;

diff --git a/libs/sdk-backend-tiger/src/backend/tigerSpecificFunctions.ts b/libs/sdk-backend-tiger/src/backend/tigerSpecificFunctions.ts
@@ -134,6 +134,7 @@ export interface IDataSourceConnectionInfo {
     name: string;
     schema: string;
     username?: string;
+    clientId?: string;
     url?: string | null;
     permissions?: IDataSourcePermission[];
     parameters?: Array<DataSourceParameter> | null;
@@ -166,6 +167,8 @@ export interface IDataSourceUpsertRequest {
     cacheStrategy?: IDataSourceCacheStrategy;
     privateKey?: string;
     privateKeyPassphrase?: string;
+    clientId?: string;
+    clientSecret?: string;
 }
 
 /**
@@ -184,6 +187,8 @@ export interface IDataSourcePatchRequest {
     cacheStrategy?: IDataSourceCacheStrategy;
     privateKey?: string | null;
     privateKeyPassphrase?: string | null;
+    clientId?: string | null;
+    clientSecret?: string | null;
 }
 
 /**
@@ -199,6 +204,8 @@ export interface IDataSourceTestConnectionRequest {
     parameters?: Array<DataSourceParameter>;
     privateKey?: string;
     privateKeyPassphrase?: string;
+    clientId?: string;
+    clientSecret?: string;
 }
 
 /**
@@ -574,6 +581,7 @@ const dataSourceResponseAsDataSourceConnectionInfo = (
         decodedParameters,
         cacheStrategy,
         authenticationType,
+        clientId,
     } = attributes;
     return {
         id,
@@ -582,6 +590,7 @@ const dataSourceResponseAsDataSourceConnectionInfo = (
         schema,
         username: username ?? undefined,
         url,
+        clientId: clientId ?? undefined,
         permissions: meta?.permissions ?? [],
         parameters,
         decodedParameters,
@@ -1036,6 +1045,8 @@ export const buildTigerSpecificFunctions = (
             cacheStrategy,
             privateKey,
             privateKeyPassphrase,
+            clientId,
+            clientSecret,
         } = requestData;
         try {
             return await authApiCall(async (sdk) => {
@@ -1055,6 +1066,8 @@ export const buildTigerSpecificFunctions = (
                                     cacheStrategy,
                                     privateKey,
                                     privateKeyPassphrase,
+                                    clientId,
+                                    clientSecret,
                                 },
                                 id,
                                 type: JsonApiDataSourceInTypeEnum.DATA_SOURCE,
@@ -1083,6 +1096,8 @@ export const buildTigerSpecificFunctions = (
             cacheStrategy,
             privateKey,
             privateKeyPassphrase,
+            clientId,
+            clientSecret,
         } = requestData;
         try {
             return await authApiCall(async (sdk) => {
@@ -1103,6 +1118,8 @@ export const buildTigerSpecificFunctions = (
                                     cacheStrategy,
                                     privateKey,
                                     privateKeyPassphrase,
+                                    clientId,
+                                    clientSecret,
                                 },
                                 id: requestDataId,
                                 type: JsonApiDataSourceInTypeEnum.DATA_SOURCE,
@@ -1131,6 +1148,8 @@ export const buildTigerSpecificFunctions = (
             cacheStrategy,
             privateKey,
             privateKeyPassphrase,
+            clientId,
+            clientSecret,
         } = requestData;
         try {
             return await authApiCall(async (sdk) => {
@@ -1151,6 +1170,8 @@ export const buildTigerSpecificFunctions = (
                                     cacheStrategy,
                                     privateKey,
                                     privateKeyPassphrase,
+                                    clientId,
+                                    clientSecret,
                                 },
                                 id: requestDataId,
                                 type: JsonApiDataSourceInTypeEnum.DATA_SOURCE,