Merge pull request #5714 from gooddata/mkn-f1-976-fix

fix: notification channels
gooddata · Dec 16, 2024 · bbdc89f · bbdc89f
2 parents 95896d3 + 4e1af08
commit bbdc89f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/.../src/presentation/widget/visualizationSwitcher/ViewModeDashboardVisualizationSwitcher.tsx b/.../src/presentation/widget/visualizationSwitcher/ViewModeDashboardVisualizationSwitcher.tsx
@@ -110,7 +110,6 @@ export const ViewModeDashboardVisualizationSwitcherContent: React.FC<
         onScheduleEmailingManagementOpen,
         isScheduledEmailingVisible,
         isScheduledManagementEmailingVisible,
-        numberOfAvailableDestinations,
     } = useDashboardScheduledEmails();
 
     const onScheduleExport = useCallback(() => {
@@ -131,7 +130,6 @@ export const ViewModeDashboardVisualizationSwitcherContent: React.FC<
     } = useAlertingAndScheduling({
         widget: activeVisualization,
         insight,
-        numberOfAvailableDestinations,
     });
 
     const { closeMenu, isMenuOpen, menuItems, openMenu } = useInsightMenu({

diff --git a/...-dashboard/src/presentation/widget/widget/InsightWidget/DefaultDashboardInsightWidget.tsx b/...-dashboard/src/presentation/widget/widget/InsightWidget/DefaultDashboardInsightWidget.tsx
@@ -56,7 +56,6 @@ const DefaultDashboardInsightWidgetCore: React.FC<
     const {
         isScheduledEmailingVisible,
         isScheduledManagementEmailingVisible,
-        numberOfAvailableDestinations,
         onScheduleEmailingOpen,
         onScheduleEmailingManagementOpen,
     } = useDashboardScheduledEmails();
@@ -88,7 +87,6 @@ const DefaultDashboardInsightWidgetCore: React.FC<
     } = useAlertingAndScheduling({
         widget,
         insight,
-        numberOfAvailableDestinations,
     });
 
     ///

diff --git a/...sdk-ui-dashboard/src/presentation/widget/widget/InsightWidget/useAlertingAndScheduling.ts b/...sdk-ui-dashboard/src/presentation/widget/widget/InsightWidget/useAlertingAndScheduling.ts
@@ -7,6 +7,7 @@ import {
     isCustomWidget,
     selectIsReadOnly,
     selectCanManageWorkspace,
+    selectNotificationChannelsCount,
 } from "../../../../model/index.js";
 import { AlertingDisabledReason, SchedulingDisabledReason } from "../../insightMenu/index.js";
 import {
@@ -19,13 +20,11 @@ import {
 type UseAlertingAndSchedulingConfig = {
     insight?: IInsight;
     widget: IInsightWidget;
-    numberOfAvailableDestinations: number;
 };
 
 export const useAlertingAndScheduling = ({
     widget,
     insight,
-    numberOfAvailableDestinations,
 }: UseAlertingAndSchedulingConfig): {
     isAlertingVisible: boolean;
     alertingDisabled: boolean;
@@ -38,6 +37,7 @@ export const useAlertingAndScheduling = ({
     const isReadOnly = useDashboardSelector(selectIsReadOnly);
     const isWorkspaceManager = useDashboardSelector(selectCanManageWorkspace);
 
+    const numberOfAvailableDestinations = useDashboardSelector(selectNotificationChannelsCount);
     /**
      * We want to hide automations when there are no destinations unless the user is admin.
      */