Skip to content

Commit

Permalink
Merge pull request #5555 from gooddata/dho/cq-893-ff
Browse files Browse the repository at this point in the history
chore: add enableFlexConnectNaming FF
  • Loading branch information
no23reason authored Nov 13, 2024
2 parents dd091d7 + ee67bdf commit 64fa2e1
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 0 deletions.
7 changes: 7 additions & 0 deletions libs/sdk-backend-tiger/src/backend/features/feature.ts
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,13 @@ export function mapFeatures(features: FeaturesMap): Partial<ITigerFeatureFlags>
"BOOLEAN",
FeatureFlagsValues.enableNewUserCreationFlow,
),
...loadFeature(
features,
TigerFeaturesNames.EnableFlexConnectNaming,
"enableFlexConnectNaming",
"BOOLEAN",
FeatureFlagsValues.enableFlexConnectNaming,
),
};
}

Expand Down
4 changes: 4 additions & 0 deletions libs/sdk-backend-tiger/src/backend/uiFeatures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export enum TigerFeaturesNames {
EnableDashboardFlexibleLayout = "enableDashboardFlexibleLayout",
EnableNumberSeparators = "enableNumberSeparators",
EnableNewUserCreationFlow = "enableNewUserCreationFlow",
EnableFlexConnectNaming = "enableFlexConnectNaming",
}

export type ITigerFeatureFlags = {
Expand Down Expand Up @@ -205,6 +206,7 @@ export type ITigerFeatureFlags = {
enableDashboardFlexibleLayout: typeof FeatureFlagsValues["enableDashboardFlexibleLayout"][number];
enableNumberSeparators: typeof FeatureFlagsValues["enableNumberSeparators"][number];
enableNewUserCreationFlow: typeof FeatureFlagsValues["enableNewUserCreationFlow"][number];
enableFlexConnectNaming: typeof FeatureFlagsValues["enableFlexConnectNaming"][number];
};

export const DefaultFeatureFlags: ITigerFeatureFlags = {
Expand Down Expand Up @@ -289,6 +291,7 @@ export const DefaultFeatureFlags: ITigerFeatureFlags = {
enableDashboardFlexibleLayout: false,
enableNumberSeparators: true,
enableNewUserCreationFlow: false,
enableFlexConnectNaming: false,
};

export const FeatureFlagsValues = {
Expand Down Expand Up @@ -377,4 +380,5 @@ export const FeatureFlagsValues = {
enableDashboardFlexibleLayout: [true, false] as const,
enableNumberSeparators: [true, false] as const,
enableNewUserCreationFlow: [true, false] as const,
enableFlexConnectNaming: [true, false] as const,
};
1 change: 1 addition & 0 deletions libs/sdk-model/api/sdk-model.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -3178,6 +3178,7 @@ export interface ISettings {
enableEarlyAccessFeaturesRollout?: boolean;
enableEmbedButtonInAD?: boolean;
enableEmbedButtonInKD?: boolean;
enableFlexConnectNaming?: boolean;
enableFlightRpcDataSource?: boolean;
enableGenAIChat?: boolean;
enableGenAIChatRollout?: boolean;
Expand Down
5 changes: 5 additions & 0 deletions libs/sdk-model/src/settings/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,11 @@ export interface ISettings {
*/
enableNewUserCreationFlow?: boolean;

/**
* Enable the use of the new FlexConnect naming (instead of FlexFunctions).
*/
enableFlexConnectNaming?: boolean;

[key: string]: number | boolean | string | object | undefined;
}

Expand Down

0 comments on commit 64fa2e1

Please sign in to comment.