Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.12 #234

Closed
wants to merge 2 commits into from
Closed

Support ghc 9.12 #234

wants to merge 2 commits into from

Conversation

erikd
Copy link

@erikd erikd commented Dec 5, 2024

No description provided.

@RyanGlScott
Copy link
Collaborator

Superseded by 75e1525.

I'll hold off on making a new th-desugar release until the corresponding changes in singletons are prepared (see goldfirere/singletons#619).

@RyanGlScott RyanGlScott closed this Dec 5, 2024
@erikd
Copy link
Author

erikd commented Dec 5, 2024

@RyanGlScott Wondering if I could have a template-haskell upper bound bump on Hackage so I can remove this from the allow-newerstanza in my cabal.project file?

@RyanGlScott
Copy link
Collaborator

RyanGlScott commented Dec 9, 2024

The current version of th-desugar on Hackage doesn't properly support template-haskell-2.23.0.0, as that version of template-haskell introduces several additions to the AST (OrP, ForallE, ForallVisE, and ConstrainedE) that will simply cause th-desugar to crash if it encounters them. (See the changes that I had to make to account for these in #221.) I'd prefer to make a new, proper Hackage release of th-desugar that handles these rather than revising the existing Hackage release into a subtly broken state.

@RyanGlScott
Copy link
Collaborator

Relatedly, if you'd like to help, I'm trying to figure out what is causing the CI issues here. I think that is the only remaining blocker for releasing new version of th-desugar/singletons/etc. (which I usually release in tandem) to Hackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants