singletons-{th,base}: Require building with GHC 9.8
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This consists of two parts: 1. Several uses of `TyVarBndrUnit` in type-level declarations had to be changed to `TyVarBndrVis` to reflect that these places can now accept both required and invisible `@`-binders. 2. The logic for generating a standalone kind signature for a singled `data` declaration (see `Data.Singletons.TH.Single.Data.singDataSAK`) had to be updated to account for invisible `@`-binders. Thanks to previous work, this is a fairly straightforward process. I have added a `Singletons.TypeAbstractions` test case to kick the tires and ensure that everything works as expected.
GHC 9.8 adds the `-Wx-partial` warning to `-Wall`, which is triggered upon any use of the partial `head` or `tail` functions from `Prelude`. This patch rewrites some code in `singletons` to avoid `head`/`tail`, and thereby avoid new warnings with GHC 9.8. Sometimes, this can be achieved by some mild refactoring, but in other cases, we simply have to accept the partiality inherent in some code and make the error cases more explicit. In addition, `-Worphans` now checks for orphan type _family_ instances in GHC 9.8 in addition to orphan type _class_ instances. The `singletons` test suite defines some orphan type family instances, so we disable this warning there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
FldNamenamespace introduced in GHC 9.8.-Wx-partialwarnings introduced in GHC 9.8.See also #564.