Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump th-desugar submodule to version 1.16 #574

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

RyanGlScott
Copy link
Collaborator

@RyanGlScott RyanGlScott commented Sep 18, 2023

This bumps the th-desugar submodule to bring in all of the changes in the upcoming 1.16 release. Aside from bumping version bounds, the only other changes that had to be made on the singletons side are:

  • singletons-th now has explicit failure cases for typed TH splices.

  • Due to Support invisible binders in type-level declarations th-desugar#194, desugared data constructors now look like this:

    DataCon :: forall (a :: Type) (b :: Type). DataType a b

    Instead of this:

    DataCon :: forall (a :: Type) (b :: Type). DataType (a :: Type) (b :: Type)

    This causes the expected output for some test cases to change, but they are benign changes.

This bumps the `th-desugar` submodule to bring in all of the changes in the
upcoming `1.16` release. Aside from bumping version bounds, the only other
changes that had to be made on the `singletons` side are:

* `singletons-th` now has explicit failure cases for typed TH splices.
* Due to goldfirere/th-desugar#194, desugared data constructors now look like
  this:

  ```hs
  DataCon :: forall (a :: Type) (b :: Type). DataType a b
  ```

  Instead of this:

  ```hs
  DataCon :: forall (a :: Type) (b :: Type). DataType (a :: Type) (b :: Type)
  ```

  This causes the expected output for some test cases to change, but they are
  benign changes.
@RyanGlScott RyanGlScott merged commit f463a38 into master Oct 10, 2023
22 checks passed
@RyanGlScott RyanGlScott deleted the th-desugar-1.16 branch October 10, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant