-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend the p2p preheat policy #21115
Open
chlins
wants to merge
1
commit into
goharbor:main
Choose a base branch
from
chlins:feat/p2p-vendor-attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
added
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
and removed
release-note/new-feature
New Harbor Feature
labels
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21115 +/- ##
==========================================
+ Coverage 45.36% 46.24% +0.87%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6420 +371
- Misses 6983 7123 +140
- Partials 301 340 +39
Flags with carried forward coverage won't be shown. Click here to find out more. |
Can you please draft a proposal for this issue? |
chlins
changed the title
feat: extend the p2p preheat policy
[WIP] feat: extend the p2p preheat policy
Dec 10, 2024
Proposal: goharbor/community#252 |
chlins
force-pushed
the
feat/p2p-vendor-attributes
branch
4 times, most recently
from
December 12, 2024 05:53
65ccbbb
to
a7420bb
Compare
chlins
changed the title
[WIP] feat: extend the p2p preheat policy
feat: extend the p2p preheat policy
Dec 12, 2024
Add the field extra_attrs to the p2p preheat policy for the provider to define their specified parameters when preheating. Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
feat/p2p-vendor-attributes
branch
from
December 12, 2024 06:06
a7420bb
to
9d49f1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
candidate/2.13.0
needs/design
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the field extra_attrs to the p2p preheat policy for the provider to define their specified parameters when preheating.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: