Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend the p2p preheat policy #21115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chlins
Copy link
Member

@chlins chlins commented Oct 30, 2024

Add the field extra_attrs to the p2p preheat policy for the provider to define their specified parameters when preheating.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins requested a review from a team as a code owner October 30, 2024 08:07
@chlins chlins added release-note/enhancement Label to mark PR to be added under release notes as enhancement and removed release-note/new-feature New Harbor Feature labels Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.24%. Comparing base (c8c11b4) to head (9d49f1b).
Report is 336 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21115      +/-   ##
==========================================
+ Coverage   45.36%   46.24%   +0.87%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6420     +371     
- Misses       6983     7123     +140     
- Partials      301      340      +39     
Flag Coverage Δ
unittests 46.24% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@stonezdj
Copy link
Contributor

stonezdj commented Nov 4, 2024

Can you please draft a proposal for this issue?

@chlins chlins changed the title feat: extend the p2p preheat policy [WIP] feat: extend the p2p preheat policy Dec 10, 2024
@chlins
Copy link
Member Author

chlins commented Dec 10, 2024

Proposal: goharbor/community#252

@chlins chlins force-pushed the feat/p2p-vendor-attributes branch 4 times, most recently from 65ccbbb to a7420bb Compare December 12, 2024 05:53
@chlins chlins changed the title [WIP] feat: extend the p2p preheat policy feat: extend the p2p preheat policy Dec 12, 2024
Add the field extra_attrs to the p2p preheat policy for the provider to
define their specified parameters when preheating.

Signed-off-by: chlins <[email protected]>
@chlins chlins force-pushed the feat/p2p-vendor-attributes branch from a7420bb to 9d49f1b Compare December 12, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate/2.13.0 needs/design release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants