Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add robot-full-permission proposal #232

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add robot-full-permission proposal #232

merged 1 commit into from
Dec 12, 2023

Conversation

AllForNothing
Copy link

Original issue goharbor/harbor#8723

1.Expose all the robot permissions on the Harbor UI for users to choose freely

@AllForNothing AllForNothing requested review from a team as code owners September 7, 2023 04:51
@AllForNothing AllForNothing force-pushed the full-permission branch 4 times, most recently from 2a11f58 to 9fc09a5 Compare September 13, 2023 09:06
@AllForNothing AllForNothing force-pushed the full-permission branch 2 times, most recently from 5c226c8 to ad834c2 Compare September 14, 2023 07:12
@AllForNothing AllForNothing force-pushed the full-permission branch 2 times, most recently from bfeee9d to 5c5fba9 Compare November 1, 2023 07:41
Vad1mo
Vad1mo requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far.
I Have the fear that this feature will overwhelm a typical Harbor day to day user and use case.
As a suggestion, can we break up this UI change into two parts?

  1. Keep the current selection with the typical dropdown is present where the use can select the common permission.

  2. Add an expert mode where the user is presented with the matrix and can select. individual permissions. What is currently displayed in the screenshots.

@AllForNothing
Copy link
Author

AllForNothing commented Nov 1, 2023 •
edited
Loading

@Vad1mo The screenshots are out of date, I will update them later.
I've refactored it based on the designer's suggestions and now it seems to be compatible with your suggestions. And I will demo the new UI in today's community meeting.

@OrlinVasilev
Copy link
Member

that would be so cool with the expert mode!!!

wy65701436
wy65701436 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 46ed85e into goharbor:main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vad1mo Vad1mo Vad1mo requested changes

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@wy65701436 wy65701436

@zyyw zyyw

@MinerYang MinerYang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AllForNothing @OrlinVasilev @Vad1mo @wy65701436 @YangJiao0817 @stonezdj @zyyw @MinerYang