Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mismatch minimum go version to match gofiber/fiber #70

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Fix mismatch minimum go version to match gofiber/fiber #70

merged 2 commits into from
Feb 26, 2024

Conversation

gaby
Copy link
Member

@gaby gaby commented Feb 24, 2024 •
edited
Loading

@gaby gaby added the ☢️ Bug Something isn't working label Feb 24, 2024
@gaby gaby requested review from a team, sixcolors, ReneWerner87 and efectn and removed request for a team February 24, 2024 22:16
@gaby
Copy link
Member Author

gaby commented Feb 24, 2024

Changing benchmark from go1.21 to go1.20 makes the compare fail.

@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 26, 2024 •
edited
Loading

image

default it the golang variant
image

so no problem

@ReneWerner87 ReneWerner87 merged commit 17c184a into master Feb 26, 2024
18 of 19 checks passed
@gaby gaby deleted the fix-gomod branch March 11, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

@sixcolors sixcolors Awaiting requested review from sixcolors sixcolors is a code owner automatically assigned from gofiber/maintainers

@efectn efectn Awaiting requested review from efectn efectn is a code owner automatically assigned from gofiber/maintainers

Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaby @ReneWerner87