Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: Nil pointer dereference with Must Bind binding #3171

Merged
merged 17 commits into from
Nov 25, 2024
Merged

🐛 fix: Nil pointer dereference with Must Bind binding #3171

merged 17 commits into from
Nov 25, 2024

Commits on Oct 17, 2024

  1. Fix nil pointer dereference with Must Bind binding error 

    if err is nil err.Error() panics
(eg. c.Bind().Must().JSON(...) successfully binds but panics
    @ItsMeSamey
    ItsMeSamey authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0fa70ab View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Added returnErr test 

    make sure returnErr works with nil error
    @ItsMeSamey
    ItsMeSamey authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    791f4ba View commit details
    Browse the repository at this point in the history

  2. Reordered returnErr nil check 

    as in majority of cases we expect err to be nil, this should provide better short-cutting
    @ItsMeSamey
    ItsMeSamey authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    dde670f View commit details
    Browse the repository at this point in the history

  3. Use require.NoError

    @gaby
    gaby authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    94d08ad View commit details
    Browse the repository at this point in the history

  4. Update bind_test.go

    @gaby
    gaby authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    b15eda0 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Renamed Must to WithAutoHandling

    @ItsMeSamey
    ItsMeSamey committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    45eb05a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gofiber:main' into main

    @ItsMeSamey
    ItsMeSamey authored Nov 16, 2024
    Configuration menu
    Copy the full SHA
    d07d360 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Merge branch 'main' into main

    @ItsMeSamey
    ItsMeSamey authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    080c001 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Update bind.md 

    Added a requested clarification
    @ItsMeSamey
    ItsMeSamey authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0cfa1c8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gofiber:main' into main

    @ItsMeSamey
    ItsMeSamey authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a7e124d View commit details
    Browse the repository at this point in the history

  3. renamed Should to WithoutAutoHandling and Bind.should to Bind.dontHandle

    @ItsMeSamey
    ItsMeSamey committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8ec9427 View commit details
    Browse the repository at this point in the history

  4. renamed dontHandle to dontHandleErrs

    @ItsMeSamey
    ItsMeSamey committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5697339 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Merge branch 'gofiber:main' into main

    @ItsMeSamey
    ItsMeSamey authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    bb172e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gofiber:main' into main

    @ItsMeSamey
    ItsMeSamey authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    254b9c6 View commit details
    Browse the repository at this point in the history

  3. fixed formatting

    @ItsMeSamey
    ItsMeSamey committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0b6b035 View commit details
    Browse the repository at this point in the history

  4. fixed a typo

    @ItsMeSamey
    ItsMeSamey committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6e667d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Update binder documentation

    @gaby
    gaby authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2a97898 View commit details
    Browse the repository at this point in the history