Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: OS.create_instance() should return -1 on failure #99694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Nov 25, 2024

I was checking if OS.create_instance() worked in exported Android games (it does not - it's unimplemented) and found that it returns 0, however, according to the docs it should return -1 on failure.

Also, within the engine itself, the OS::get_singleton()->create_instance() returns Error rather than the PID integer, and that would return OK in exported Android games, whereas it should probably return FAILED, because it doesn't actually work.

A super minor thing because it's unimplemented, but if someone wrote cross-platform code and expected -1 in the case of failure, it could potentially create problems.

@dsnopek dsnopek added this to the 4.4 milestone Nov 25, 2024
@dsnopek dsnopek requested a review from m4gr3d November 25, 2024 22:05
@dsnopek dsnopek requested a review from a team as a code owner November 25, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant