Android: OS.create_instance()
should return -1
on failure
#99694
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking if
OS.create_instance()
worked in exported Android games (it does not - it's unimplemented) and found that it returns0
, however, according to the docs it should return-1
on failure.Also, within the engine itself, the
OS::get_singleton()->create_instance()
returnsError
rather than the PID integer, and that would returnOK
in exported Android games, whereas it should probably returnFAILED
, because it doesn't actually work.A super minor thing because it's unimplemented, but if someone wrote cross-platform code and expected
-1
in the case of failure, it could potentially create problems.