Fix get_item_area_rect when tree is scrolled

[Giganzo]

Fixes: #102115

Updated with more fixes, see #102116 (comment)

Fixes: #71997

[bruvzg]

The change looks good and seems to be working as expected.

But some places in the editor code use this and do adjust for scroll manually, so these should be changed as well.

godot/editor/plugins/animation_library_editor.cpp

Line 648 in 6dc78c8

Vector2 popup_pos = tree->get_screen_transform().xform(pos.position + Vector2(0, pos.size.height)) - tree->get_scroll();

godot/editor/plugins/animation_library_editor.cpp

Line 608 in 6dc78c8

Vector2 popup_pos = tree->get_screen_transform().xform(pos.position + Vector2(0, pos.size.height)) - tree->get_scroll();

[Giganzo]

But some places in the editor code use this and do adjust for scroll manually, so these should be changed as well.
...

Fixed in animation_library_editor.cpp.

Other issues

Found some other already existing issues, that I currently don't know how to fix.

RtL

Rect position of specified column is not correct when control is set to RtL

Screencast_20250128_091631.webm

Button and expanding columns

Buttons rect position is not correct. Believe it is because it's using full width even when columns is not fully expanded.

Should these issues be reported as separate issues that can be fixed in a new pr?

[bruvzg]

Should these issues be reported as separate issues that can be fixed in a new pr?

If you already have a fix, it can be added directly to this PR, if not open a new issue.

[Giganzo]

If you already have a fix, it can be added directly to this PR, if not open a new issue.

I have some potential fixes for some of the other issues, the RtL is actually two different issues. Should I still push the fixes to this PR (might be a day or two)?

But also discovered more issues with the tree, don't think I can solve all of them or if they would be correct to put in this PR. If they are not already reported I will make new issues for them later.

[Giganzo]

Updated PR with new fixes.

RtL

Should now work for column and buttons.

Button rect

1. Now works when tree is scrolled horizontally.
2. Height is the full size.

There is an issue #100645 with the buttons jiggiling when scrolling horizontally. This makes the rect be slightly off in some cases. But the fix should most likley be to stop them from jiggiling around.

Theme properies

Should account for theme properties now. Fixes: #71997

Not sure if the first option (TreeItem) should include horizontal theme properties or not. Can add them in if they should be accounted for.

Description

There might also be a problem with the description, it says:

If column is specified, only get the position and size of that column, otherwise get the rectangle containing all columns.

It sounds like it should give a rect that have the size of all combined columns when only specifing a TreeItem?
This has never been the case, from what I can see. So maybe the documentation needs to change?