-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooling updates #1074
Tooling updates #1074
Conversation
Ugh... an ICE in the Unfortunately I don't have the time to debug/minimize that right now 😕 |
Ugh. I think it's the same ICE that I've ran into earlier here. Haven't had the time to debug it properly yet either. I guess we can also just report the issue immediately. It's more work for upstream but I'd imagine them to be much better at debugging ICEs than either of us, and some report is better than nothing. |
Agree. Do you have time to report it, or should I? |
I've created rust-lang/rust-clippy#12616. |
That was fixed insanely fast 👀 I guess we have to wait until next stable, unless we change CI config? |
Probably. I don't think waiting for a stable release should be much of a problem for this repo, vs changing the CI config now only to have to change it back in a few more weeks. It would be productive to check locally with nightly after the changes get released in one of course, just to make sure that there isn't anything else the MCVE failed to capture. |
(coming from the clippy issue since I saw it linked) gdnative/gdnative-core/src/object/mod.rs Line 358 in 7e55836
fwiw, I did verify that clippy no longer ICEs on this crate with the fix applied
|
ICE was fixed in the meantime, this addresses the problem until next stable release.
Thanks a lot @y21, also for the very fast clippy fix. It's really appreciated! ❤️ |
@chitoyuu Addressed several things to make CI green again -- see initial message for details. Nightly clippy has a lot of warnings that would take significant maintenance effort (moving around imports, refactoring |
The macro parse_quote_spanned!() has been introduced there.
Make CI work again, and modernize things a bit.
Changes:
actions-rs
toolchain with directrustup
callsactions/checkout
,actions/cache
cargo-dinghy
,cargo-deny
,cargo-machete
Closes #1073.