-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more verbose in case of signature check failures #361
Conversation
…ture check failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Download attempt for working signatures unchanged, for signature check failure now also puts out a reason: Signature Verification Error: Invalid signature)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came a cross a weird output:
{
"num": 20,
"description": "Public OpenPGP Key",
"messages": [
{
"type": 0,
"text": "No OpenPGP keys loaded."
},
{
"type": 0,
"text": "1 public OpenPGP key(s) loaded."
}
]
}
]
}
],
"version": "2.1.1-21-g7eadf00",
This wasn't the case before:
{
"num": 20,
"description": "Public OpenPGP Key",
"messages": [
{
"type": 0,
"text": "2 public OpenPGP key(s) loaded."
}
]
}
]
}
],
"version": "2.1.1-20-g3590cf1",
Good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also simplify handling of signature keys.
For #358