Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more verbose in case of signature check failures #361

Merged
merged 4 commits into from
May 5, 2023

Conversation

s-l-teichmann
Copy link
Contributor

Also simplify handling of signature keys.

For #358

JanHoefelmeyer
JanHoefelmeyer previously approved these changes Apr 26, 2023
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Download attempt for working signatures unchanged, for signature check failure now also puts out a reason: Signature Verification Error: Invalid signature)

Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came a cross a weird output:

{
          "num": 20,
          "description": "Public OpenPGP Key",
          "messages": [
            {
              "type": 0,
              "text": "No OpenPGP keys loaded."
            },
            {
              "type": 0,
              "text": "1 public OpenPGP key(s) loaded."
            }
          ]
        }
      ]
    }
  ],
  "version": "2.1.1-21-g7eadf00",

This wasn't the case before:

{
          "num": 20,
          "description": "Public OpenPGP Key",
          "messages": [
            {
              "type": 0,
              "text": "2 public OpenPGP key(s) loaded."
            }
          ]
        }
      ]
    }
  ],
  "version": "2.1.1-20-g3590cf1",

@s-l-teichmann
Copy link
Contributor Author

I came a cross a weird output:

{
          "num": 20,
          "description": "Public OpenPGP Key",
          "messages": [
            {
              "type": 0,
              "text": "No OpenPGP keys loaded."
            },
            {
              "type": 0,
              "text": "1 public OpenPGP key(s) loaded."
            }
          ]
        }
      ]
    }
  ],
  "version": "2.1.1-21-g7eadf00",

This wasn't the case before:

{
          "num": 20,
          "description": "Public OpenPGP Key",
          "messages": [
            {
              "type": 0,
              "text": "2 public OpenPGP key(s) loaded."
            }
          ]
        }
      ]
    }
  ],
  "version": "2.1.1-20-g3590cf1",

Good catch!
Commit 87ab2ed should solve this.

Copy link
Collaborator

@tschmidtb51 tschmidtb51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works

Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann merged commit c263391 into main May 5, 2023
@s-l-teichmann s-l-teichmann deleted the verbose-signature-check branch May 5, 2023 13:02
@bernhardreiter bernhardreiter added this to the Release 2.2.0 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants